-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][Android] Update react-native-svg
to 13.4.0
#19434
Conversation
Superseed #19080 |
Do we still need the patch file for |
4483eec
to
cb0c370
Compare
react-native-svg
to 13.3.0
react-native-svg
to 13.4.0
It seems to be needed 🤷 |
cb0c370
to
7c7ed45
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Changelog entry in wrong CHANGELOG file
Generated by ExpoBot 🤖 against 7c7ed45 |
# Why `CHANGELOG.md` has incorrect version of dependency `react-native-svg` from recent PR #19434 # How Did not build or test (N/A) # Test Plan Did not build or test (N/A) # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
Is that possible to bump version of Asking because we have a crash on android on 13.4 version: When 13.4 installed bare RN crashes with this error, bumping to 13.6 fixes native crash but when I launch it in Expo go we have this issue... I suspect (hope) that it will resolve the issue. upd: seems like smth related to react-native-svg-transformer... cc/ @lukmccall |
Why
Closes ENG-6532.
How
Run:
Test Plan